Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone changes (TIP-29) #1347

Merged
merged 19 commits into from
Apr 22, 2022
Merged

Milestone changes (TIP-29) #1347

merged 19 commits into from
Apr 22, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Apr 20, 2022 •
edited
Loading

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez changed the title Milestone timestamp as u32 Milestone changes Apr 20, 2022
@thibault-martinez thibault-martinez added wg-message Working Group - Message c-enhancement Category - Enhancement e-medium Experience - Medium p-high Priority - High n-shimmer Network - Shimmer labels Apr 20, 2022
@thibault-martinez thibault-martinez marked this pull request as ready for review April 21, 2022 09:55
@thibault-martinez thibault-martinez changed the title Milestone changes Milestone changes (TIP-29) Apr 21, 2022
samuel-rufi
samuel-rufi previously approved these changes Apr 21, 2022
View reviewed changes
grtlr
grtlr previously approved these changes Apr 22, 2022
View reviewed changes
samuel-rufi
samuel-rufi previously approved these changes Apr 22, 2022
View reviewed changes
@thibault-martinez @Alex6323
Update bee-message/src/payload/milestone/option/mod.rs
ed2b903 
Co-authored-by: /alex/ <alexander.schmidt@iota.org>
Alex6323
Alex6323 previously approved these changes Apr 22, 2022
View reviewed changes
@thibault-martinez thibault-martinez merged commit ebf741d into iotaledger:shimmer-develop Apr 22, 2022
@thibault-martinez thibault-martinez deleted the milestone-changes branch April 22, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

@bingyanglin bingyanglin bingyanglin approved these changes

@grtlr grtlr Awaiting requested review from grtlr

@pvdrz pvdrz Awaiting requested review from pvdrz

Assignees
No one assigned
Labels
c-enhancement Category - Enhancement e-medium Experience - Medium n-shimmer Network - Shimmer p-high Priority - High wg-message Working Group - Message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thibault-martinez @grtlr @samuel-rufi @pvdrz @Alex6323 @bingyanglin